Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operations): Set alter_async=0 when dropping an index asynchronously #6237

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Aug 22, 2024

No description provided.

@phacops phacops requested a review from a team as a code owner August 22, 2024 21:39
@phacops phacops enabled auto-merge (squash) August 22, 2024 21:45
Copy link

codecov bot commented Aug 22, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1155 1 1154 2
View the top 1 failed tests by shortest run time
tests.migrations.test_operations test_drop_index_async
Stack Traces | 0.003s run time
Traceback (most recent call last):
  File ".../tests/migrations/test_operations.py", line 175, in test_drop_index_async
    assert (
AssertionError: assert ('ALTER TABLE test_table DROP INDEX IF EXISTS index_1 SETTINGS '\n 'mutations_sync=0, alter_sync=0;') == 'ALTER TABLE test_table DROP INDEX IF EXISTS index_1 SETTINGS mutations_sync=0;'
  - ALTER TABLE test_table DROP INDEX IF EXISTS index_1 SETTINGS mutations_sync=0;
  + ALTER TABLE test_table DROP INDEX IF EXISTS index_1 SETTINGS mutations_sync=0, alter_sync=0;
  ?                                                                              ++++++++++++++

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@phacops phacops merged commit b96385a into master Aug 22, 2024
30 checks passed
@phacops phacops deleted the pierre/force-async-everything branch August 22, 2024 22:18
@getsentry-bot
Copy link
Contributor

PR reverted: 4b5d202

getsentry-bot added a commit that referenced this pull request Aug 28, 2024
…nchronously (#6237)"

This reverts commit b96385a.

Co-authored-by: phacops <336345+phacops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants