fix: store event ID (it is not in tags) #6291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
requested changes
Sep 11, 2024
| @@ -133,6 +133,9 @@ impl From<FromSpanMessage> for EAPSpan { | |||
| attr_num_buckets[(fnv_1a(k.as_bytes()) as usize) % attr_num_buckets.len()] | |||
| .insert(k.clone(), v); | |||
| }; | |||
| if let Some(event_id) = from.event_id { | |||
| insert_string("sentry.event_id".into(), event_id.to_string()) | |||
There was a problem hiding this comment.
Can you remove dashes from it?
|
What's the motivation behind this change? |
|
Needed for trace view, I'll close this since @mitsuhiko says "migrating entirely away from event id" is in scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason event ID is sent normalized and not in any _tags fields, pull it out explicitly.