Revert "fix(eap): Switch to sampling_weight_2 in entity (#6287)" #6296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This reverts commit e7fe504. since sampling_weight_2 isn't currently populated. Sentry code is going to do a `toUInt64` in the meantime so we can test
colin-sentry
requested changes
Sep 12, 2024
| @@ -23,7 +23,6 @@ schema: | |||
| { name: name, type: String }, | |||
| { name: sampling_factor, type: Float, args: { size: 64 } }, | |||
| { name: sampling_weight, type: Float, args: { size: 64 } }, | |||
| { name: sampling_weight_2, type: UInt, args: { size: 64 } }, | |||
There was a problem hiding this comment.
This PR seems to have weird merge conflict with https://github.com/getsentry/snuba/pull/6290/files#diff-438e988ddb8c60638398f11a2f2232da05c36cd13ed90683531bd73bc6418779R25-R27 - you can refer to the float version with sampling_weight above, no need to delete sampling_weight_2 ?
|
closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toUInt64in the meantime so we can test