Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(eap): Allow more memory usage for eap spans #6298

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

volokluev
Copy link
Member

No description provided.

@volokluev volokluev requested review from a team as code owners September 12, 2024 20:07
@volokluev volokluev enabled auto-merge (squash) September 12, 2024 20:17
Copy link

codecov bot commented Sep 12, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2614 1 2613 4
View the top 1 failed tests by shortest run time
tests.web.rpc.test_span_samples.TestSpanSamples test_basic
Stack Traces | 0.327s run time
Traceback (most recent call last):
  File ".../web/rpc/test_span_samples.py", line 143, in test_basic
    assert response.status_code == 200, response.text
AssertionError: {
      "error": {
          "type": "internal_server_error",
          "message": "DB::Exception: Unexpected value of OverflowModeGroupBy: 'None'. Must be one of ['any', 'break', 'throw']. Stack trace:\n\n0. DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0xe295a55 in ..................................../usr/bin/clickhouse\n1. DB::SettingFieldOverflowModeGroupByTraits::fromString(std::basic_string_view<char, std::char_traits<char>>) @ 0x12ac85b8 in ..................................../usr/bin/clickhouse\n2. ? @ 0x12a2ad1f in ..................................../usr/bin/clickhouse\n3. DB::BaseSettings<DB::SettingsTraits>::read(DB::ReadBuffer&, DB::SettingsWriteFormat) @ 0x12997fda in ..................................../usr/bin/clickhouse\n4. DB::TCPHandler::receiveQuery() @ 0x14bc3ee6 in ..................................../usr/bin/clickhouse\n5. DB::TCPHandler::receivePacket() @ 0x14bbba7e in ..................................../usr/bin/clickhouse\n6. DB::TCPHandler::runImpl() @ 0x14bb29e6 in ..................................../usr/bin/clickhouse\n7. DB::TCPHandler::run() @ 0x14bc9699 in ..................................../usr/bin/clickhouse\n8. Poco::Net::TCPServerConnection::start() @ 0x17b1ec54 in ..................................../usr/bin/clickhouse\n9. Poco::Net::TCPServerDispatcher::run() @ 0x17b1fe7b in ..................................../usr/bin/clickhouse\n10. Poco::PooledThread::run() @ 0x17ca8e27 in ..................................../usr/bin/clickhouse\n11. Poco::ThreadImpl::runnableEntry(void*) @ 0x17ca689d in ..................................../usr/bin/clickhouse\n12. ? @ 0x7f7d2b99e609 in ?\n13. __clone @ 0x7f7d2b8c3353 in ?\n"
      }
  }
assert 500 == 200
 +  where 500 = <WrapperTestResponse streamed [500 INTERNAL SERVER ERROR]>.status_code

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@volokluev volokluev merged commit 6c680fe into master Sep 12, 2024
30 checks passed
@volokluev volokluev deleted the volo/eap/moar_mems branch September 12, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants