feat(job-runner): track job status #6332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xurui-c
changed the title
status subcommand for snuba jobs
xurui-c
changed the title
status subcommand for snuba jobs
xurui-c
force-pushed
the
rachel/status
branch
from
b05d98e
to
c0270df
Compare
xurui-c
commented
Sep 20, 2024
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
onewland
reviewed
Sep 20, 2024
onewland
reviewed
Sep 27, 2024
onkar
reviewed
Sep 30, 2024
onkar
approved these changes
Oct 1, 2024
|
PR reverted: bb814d3 |
getsentry-bot
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit a94f00f. Co-authored-by: onewland <130124+onewland@users.noreply.github.com>
onewland
added a commit
that referenced
this pull request
Oct 2, 2024
This is #6332 unchanged, but now Redis clusters have been defined in all SaaS environments (getsentry/ops#12293 deployed everywhere)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track job status to prevent double executions
Making a few changes here:
JobSpecthe main way to call run_job and run_job the main interface for executing manual jobsrun_job, acquire a lock via a redis key or abort the attempted executionrun_job, also abort execution if the job_id contains a non-null/"not started" statusJIRA: https://getsentry.atlassian.net/browse/SNS-2869