ref(deletes): add use_bulk_deletes runtime config #6560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onkar
approved these changes
Nov 12, 2024
snuba/web/views.py
Outdated
| request_parts.query["query"]["columns"], | ||
| request_parts.attribution_info, | ||
| ) | ||
| if get_config("use_bulk_deletes", False): |
There was a problem hiding this comment.
The default is False but shouldn't we set use_bulk_delete to False using set_config() in this PR and flip it to True once we are ready to use bulk delete in s4s? Also, the note on
Line 190 in ce29277
get_config() is supposed to be deprecated. Does it make sense to add a function in snuba/state that returns bool and use it here?
There was a problem hiding this comment.
oh didn't see that comment - I'll update
and I can set the default to be 0 and use get_int_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a temporary runtime config (
use_bulk_deletes) to allow for delete queries to go through the bulk delete pipeline, until we are ready to fully move over to using it.I choose a runtime config because I didn't want sentry to have to be aware of which implementation was used (bulk deletes or not).
We should only enable this when we have the consumers running in S4S