really fix it now?

getsentry · Aug 21, 2024 · 5e51d6c · 5e51d6c
1 parent d334a2b
commit 5e51d6c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/overlay/src/integrations/sentry/data/sentryDataCache.ts b/packages/overlay/src/integrations/sentry/data/sentryDataCache.ts
@@ -44,7 +44,7 @@ class SentryDataCache {
  initial.forEach(e => this.pushEvent(e));
  }
 
- setSidecarUrl(url: string) {
+ setSidecarUrl(url: string | null) {
  if (!url) {
  this.contextLinesProvider = null;
  return;

diff --git a/packages/overlay/src/integrations/sentry/index.ts b/packages/overlay/src/integrations/sentry/index.ts
@@ -31,6 +31,8 @@ export default function sentryIntegration(options: SentryIntegrationOptions = {}
  }
  if (options.sidecarUrl) {
  sentryDataCache.setSidecarUrl(options.sidecarUrl);
+ } else if ('sidecarUrl' in options) {
+ sentryDataCache.setSidecarUrl(null);
  }
  addSpotlightIntegrationToSentry(options);