ref(stacktrace-symbolication): Guard requests and parsing

.changeset/smooth-pandas-press.md

@@ -0,0 +1,5 @@
+---
+'@spotlightjs/core': patch
+---
+
+ref(core): Guard calls to symbolication endpoint

.changeset/warm-countries-own.md

@@ -0,0 +1,5 @@
+---
+'@spotlightjs/astro': patch
+---
+
+ref(astro): Guard requests and parsing in Vite Symbolication plugin

packages/astro/src/vite/source-context.ts

@@ -35,16 +35,24 @@ export const sourceContextPlugin: () => Plugin = () => ({
  });
 
  req.on('end', async () => {
- const stacktrace: SentryStackTrace = JSON.parse(requestBody);
+ const stacktrace = parseStackTrace(requestBody);
+
+ if (!stacktrace) {
+ res.writeHead(500);
+ res.end();
+ return;
+ }
 
  for (const frame of stacktrace.frames ?? []) {
  if (
  isValidSentryStackFrame(frame) &&
  // let's ignore dependencies for now with this naive check
  !frame.filename.includes('/node_modules/')
  ) {
- const generatedCodeResponse = await fetch(frame.filename);
- const generatedCode = await generatedCodeResponse.text();
+ const generatedCode = await getGeneratedCodeFromServer(frame.filename);
+ if (!generatedCode) {
+ continue;
+ }
 
  // Extract the inline source map from the minified code
  const inlineSourceMapMatch = generatedCode.match(
@@ -71,6 +79,23 @@ export const sourceContextPlugin: () => Plugin = () => ({
  },
 });
 
+async function getGeneratedCodeFromServer(filename: string): Promise<string | undefined> {
+ try {
+ const generatedCodeResponse = await fetch(filename);
+ return generatedCodeResponse.text();
+ } catch {
+ return undefined;
+ }
+}
+
+function parseStackTrace(requestBody: string): SentryStackTrace | undefined {
+ try {
+ return JSON.parse(requestBody) as SentryStackTrace;
+ } catch {
+ return undefined;
+ }
+}
+
 async function applySourceContextToFrame(sourceMapContent: string, frame: ValidSentryStackFrame) {
  const consumer = await new SourceMap.SourceMapConsumer(sourceMapContent);
 

packages/core/src/integrations/sentry/sentry-integration.ts

@@ -11,13 +11,21 @@ export class Spotlight implements Integration {
  }
 
  for (const exception of event.exception.values ?? []) {
- console.log('fetching', exception);
- const stackTraceWithContextResponse = await fetch('/spotlight/contextlines', {
- method: 'PUT',
- body: JSON.stringify(exception.stacktrace),
- });
- const stackTraceWithContext = await stackTraceWithContextResponse.json();
- exception.stacktrace = stackTraceWithContext;
+ try {
+ const stackTraceWithContextResponse = await fetch('/spotlight/contextlines', {
+ method: 'PUT',
+ body: JSON.stringify(exception.stacktrace),
+ });
+
+ if (!stackTraceWithContextResponse.ok || stackTraceWithContextResponse.status !== 200) {
+ continue;
+ }
+
+ const stackTraceWithContext = await stackTraceWithContextResponse.json();
+ exception.stacktrace = stackTraceWithContext;
+ } catch {
+ // Something went wrong, for now we just ignore it.
+ }
  }
  return event;
  });