fix(core): Cleanup spotlight event target listeners (#104)

* fix(core): Cleanup spotlight event target listeners * changeset
getsentry · Nov 22, 2023 · 76721fd · 76721fd
1 parent 72ca15e
commit 76721fd
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 6 deletions.
diff --git a/.changeset/seven-carrots-shop.md b/.changeset/seven-carrots-shop.md
@@ -0,0 +1,5 @@
+---
+'@spotlightjs/core': patch
+---
+
+fix(core): Use effect and cleanup spotlight event target listeners
diff --git a/packages/core/src/App.tsx b/packages/core/src/App.tsx
@@ -56,13 +56,23 @@ export default function App({
     };
   }, [integrations, sidecar]);
 
-  eventTarget.addEventListener('open', () => {
-    setOpen(true);
-  });
+  useEffect(() => {
+    const onOpen = () => {
+      setOpen(true);
+    };
+
+    const onClose = () => {
+      setOpen(false);
+    };
 
-  eventTarget.addEventListener('close', () => {
-    setOpen(false);
-  });
+    eventTarget.addEventListener('open', onOpen);
+    eventTarget.addEventListener('close', onClose);
+
+    return () => {
+      eventTarget.removeEventListener('open', onOpen);
+      eventTarget.removeEventListener('close', onClose);
+    };
+  }, [eventTarget]);
 
   useEffect(() => {
     if (!isOpen) {