Skip to content

Commit

Permalink
ci: Fix auto publishing to Docker & Electron
Browse files Browse the repository at this point in the history
As seen from #484, we don't automatically publish to Docker and Electron targets. The reason for this is we have an strict `inputs.docker` and `inputs.electron` check, assuming they will have a default value of `true`. That said the `input` context only gets populated on a manually triggered workflow, hence these jobs get skipped on auto publish actions. This PR should fix the issue by replacing it with an explicit `!= false` check, so it becomes `true` if the value is `null` or `undefined`.
  • Loading branch information
BYK committed Aug 12, 2024
1 parent 88b1206 commit bdfa53d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
runs-on: ubuntu-latest
if: |
!cancelled()
&& inputs.docker
&& inputs.docker != false
&& (needs.npm.result == 'success' || needs.npm.result == 'skipped')
steps:
- name: Checkout Repo
Expand Down Expand Up @@ -102,7 +102,7 @@ jobs:
runs-on: macos-latest
if: |
!cancelled()
&& inputs.electron
&& inputs.electron != false
&& (needs.npm.result == 'success' || needs.npm.result == 'skipped')
# strategy:
# fail-fast: false
Expand Down

0 comments on commit bdfa53d

Please sign in to comment.