fix(core): Ensure there's only one global spotlight event target #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of a workaround for #68 which should ensure that even if two spotlight bundle variants end up in the build, still the same event target is used for communication. Not ideal and I'd like to revisit this but for now it should permit opening spotlight in astro apps again (🤞)
This change puts the eventTarget of spotlight onto the global
window
, thereby ensuring that all bundles get the same instance of the target.Ideally, we find a way to avoid the double bundling un Astro but we might still keep this around. I have the feeling that something like this could occur in other framework/bundler combinations.