Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement and code refactoring #148

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

Shubhdeep12
Copy link
Collaborator

fixes: #147

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 9:27am

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (003ebfd) 32.12% compared to head (4376fad) 32.22%.

Files Patch % Lines
...egrations/sentry/components/Events/Error/Frame.tsx 0.00% 19 Missing ⚠️
...src/integrations/sentry/components/SpanDetails.tsx 0.00% 11 Missing ⚠️
...rc/integrations/sentry/components/TraceDetails.tsx 0.00% 6 Missing ⚠️
...ay/src/integrations/sentry/components/SpanTree.tsx 0.00% 5 Missing ⚠️
packages/overlay/src/components/SidePanel.tsx 0.00% 4 Missing ⚠️
packages/overlay/src/components/Tabs.tsx 0.00% 4 Missing ⚠️
...ntegrations/sentry/components/EventBreadcrumbs.tsx 0.00% 4 Missing ⚠️
...y/src/integrations/sentry/components/EventList.tsx 0.00% 4 Missing ⚠️
...y/src/integrations/sentry/components/TraceList.tsx 0.00% 4 Missing ⚠️
...c/integrations/sentry/components/EventContexts.tsx 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   32.12%   32.22%   +0.09%     
==========================================
  Files          34       34              
  Lines        1628     1623       -5     
  Branches       63       63              
==========================================
  Hits          523      523              
+ Misses       1105     1100       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HazAT HazAT merged commit 8eb75ef into getsentry:main Nov 28, 2023
4 of 5 checks passed
@Shubhdeep12 Shubhdeep12 deleted the fix/enhancement-and-refactoring branch December 4, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Refactoring and Enhancements
2 participants