Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(overlay): Add onOpen and onSevereEvent callbacks #161

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 28, 2023

This PR adds two public API callbacks:

  • onOpen - fired when the debug window is opened
  • onSevereEvent - fired when an integration processes and returns a severe event

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 6:10pm

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49d4491) 32.73% compared to head (1207bc9) 32.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   32.73%   32.73%           
=======================================
  Files          36       36           
  Lines        1720     1720           
  Branches       63       63           
=======================================
  Hits          563      563           
  Misses       1157     1157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lms24 Lms24 merged commit 71b31ef into main Nov 28, 2023
6 checks passed
@Lms24 Lms24 deleted the lms/feat-overlay-callbacks branch November 28, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant