ref(overlay): Rename fullscreen option to openOnInit
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the name was missleading, suggesting it'd make open the overlay in fullscreen rather than windowed mode, which it never did. The only thing this option does is controlling if the overlay window should be opened immediately when the UI is rendered or if just the button should be displayed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
=======================================
Coverage 32.52% 32.52%
=======================================
Files 36 36
Lines 1734 1734
Branches 63 63
=======================================
Hits 564 564
Misses 1170 1170 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the name was missleading, suggesting it'd make open the overlay
in fullscreen rather than windowed mode, which it never did.
The only thing this option does is controlling if the overlay window
should be opened immediately when the UI is rendered or if just the
button should be displayed.