-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add IIFE bundle for single script include #478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds an Immediately Invoked Function Expression (IIFE) bundle which automatically initializes Spotlight upon loading. Greatly simplifies the HTML include method for Spotlight. It also fixes a bug where Spotlight won't be initialized if it loads after page `load` event and `injectImmediately` was not set to `true`.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me from a technical perspective!
BYK
pushed a commit
that referenced
this pull request
Aug 7, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/overlay@2.3.0 ### Minor Changes - Add IIFE for auto load & init over CDN with a single script include ([#478](#478)) ### Patch Changes - Overhaul React code for multiple fixes and performance improvements ([#473](#473)) - Various improvements in React code for better stability & performance ([#476](#476)) ## @spotlightjs/astro@2.1.6 ### Patch Changes - Various improvements in React code for better stability & performance ([#476](#476)) - Updated dependencies \[[`d38c054a47820fe074ad3fd61fe5960e85e0ef49`](d38c054), [`8f42d4e6b97d3503c36447c0ba6ffa1ebea72ccf`](8f42d4e)]: - @spotlightjs/spotlight@2.3.1 ## @spotlightjs/electron@1.1.4 ### Patch Changes - Overhaul React code for multiple fixes and performance improvements ([#473](#473)) - Various improvements in React code for better stability & performance ([#476](#476)) - Updated dependencies \[[`d38c054a47820fe074ad3fd61fe5960e85e0ef49`](d38c054), [`12ac07d7e270a48fee308e6d89495417bc06f943`](12ac07d), [`8f42d4e6b97d3503c36447c0ba6ffa1ebea72ccf`](8f42d4e)]: - @spotlightjs/overlay@2.3.0 ## @spotlightjs/spotlight@2.3.1 ### Patch Changes - Overhaul React code for multiple fixes and performance improvements ([#473](#473)) - Various improvements in React code for better stability & performance ([#476](#476)) - Updated dependencies \[[`d38c054a47820fe074ad3fd61fe5960e85e0ef49`](d38c054), [`12ac07d7e270a48fee308e6d89495417bc06f943`](12ac07d), [`8f42d4e6b97d3503c36447c0ba6ffa1ebea72ccf`](8f42d4e)]: - @spotlightjs/overlay@2.3.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an Immediately Invoked Function Expression (IIFE) bundle which automatically initializes Spotlight upon loading. Greatly simplifies the HTML include method for Spotlight.
It also fixes a bug where Spotlight won't be initialized if it loads after page
load
event andinjectImmediately
was not set totrue
.