ci: Fix auto publishing to Docker & Electron #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As seen from #484, we don't automatically publish to Docker and Electron targets. The reason for this is we have an strict `inputs.docker` and `inputs.electron` check, assuming they will have a default value of `true`. That said the `input` context only gets populated on a manually triggered workflow, hence these jobs get skipped on auto publish actions. This PR should fix the issue by replacing it with an explicit `!= false` check, so it becomes `true` if the value is `null` or `undefined`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen from #484, we don't automatically publish to Docker and Electron targets. The reason for this is we have an strict
inputs.dockerandinputs.electroncheck, assuming they will have a default value oftrue. That said theinputcontext only gets populated on a manually triggered workflow, hence these jobs get skipped on auto publish actions. This PR should fix the issue by replacing it with an explicit!= falsecheck, so it becomestrueif the value isnullorundefined.