fix: Fix infinite render loops for values from DB #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BYK
pushed a commit
that referenced
this pull request
Sep 12, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/astro@2.1.9 ### Patch Changes - Fixed infinite render loops and optimized rerenders ([#522](#522)) - Updated dependencies \[[`df9cd954323648d8c22e61643520a1642b8884ca`](df9cd95)]: - @spotlightjs/spotlight@2.4.1 ## @spotlightjs/electron@1.1.9 ### Patch Changes - Fixed infinite render loops and optimized rerenders ([#522](#522)) - Updated dependencies \[[`df9cd954323648d8c22e61643520a1642b8884ca`](df9cd95)]: - @spotlightjs/overlay@2.5.1 ## @spotlightjs/overlay@2.5.1 ### Patch Changes - Fixed infinite render loops and optimized rerenders ([#522](#522)) ## @spotlightjs/spotlight@2.4.1 ### Patch Changes - Fixed infinite render loops and optimized rerenders ([#522](#522)) - Updated dependencies \[[`df9cd954323648d8c22e61643520a1642b8884ca`](df9cd95)]: - @spotlightjs/overlay@2.5.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pach overhauls the initial rerender with better use of hooks, namely
useCallbackbut also using intial state creation function to fix the infinite render loop reported in #521.Fixes #521.