ref: Add special case for extracting name of rewritten async function in Dart lang #1246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately
dart_web
is setting the platform tojavascript
for this variant of the SDK, so we cannot use it to make any distinction between the incoming events.It appears that there is no way to make a distinction between regular JS code and the scenario we're solving here :(
The only way that I found is indeed actually using
scope.startsWith('$async$')
- https://github.com/dart-lang/sdk/blob/main/pkg/compiler/lib/src/js_backend/namer.dart#L1845-L1866@marandaneto could you please provide us with the most barebone repo case for this? Basically, a single async function that throws?
I don't want to commit 62k lines of fixtures for such a simple test case.
Fixes getsentry/symbolic#791