-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some documentation for encrypting with age #1001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've added two comments. Could you please rebase the result, and squash everything into one commit and make sure to sign off on it (for DCO)? Thanks.
Can you please squash the commits and sign-off on the resulting commit (see https://github.com/getsops/sops/pull/1001/checks?check_run_id=16863365696)? |
Sure thing, will do it tonight or tomorrow. |
* Match file path relative to config file's directory * Update README.rst Signed-off-by: Carsten Skov <carsten@simcax.dk>
Signed-off-by: Carsten Skov <carsten@simcax.dk>
corrected path to keys based on the real behavior. see [1] [1] https://github.com/mozilla/sops/blob/master/age/keysource.go#L108 Signed-off-by: Carsten Skov <carsten@simcax.dk>
Signed-off-by: Carsten Skov <carsten@simcax.dk>
…etsops#906) * `golang.org/x/crypto/openpgp` requires keys contain identity information. * A email address can have only a single key with identity information on keys.openpgp.org. Signed-off-by: Carsten Skov <carsten@simcax.dk>
Fixed formatting for example of multiple age keys in .sops.yaml Added example of using updatekeys with age Apply suggestions from code review Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> Signed-off-by: Carsten Skov <carsten@simcax.dk>
"regexp" | ||
"strings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR now contains changes that should not be part of it. I guess something went wrong during rebasing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I must have messed it up. Will give it a look again - sorry about the mess @felixfontein
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, such things happen ;-) Better look at the "File changed" view on GitHub (https://github.com/getsops/sops/pull/1001/files) next time after rebasing to see whether the result looks as expected.
Ping @simcax |
I have added some examples of having age recipients in the .sops.yaml as well as a little info about using it with updatekeys