Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v3.8.0-rc.1 #1268

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Prepare v3.8.0-rc.1 #1268

merged 1 commit into from
Aug 25, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Aug 24, 2023

For "release note", see: #1266

This does not bump the version.Version variable, as this is already done by the build process and this release itself is a release candidate. When the --version flag in an existing sops binary would already make use of the GitHub API, it would not report it as "latest" either.

@hiddeco hiddeco force-pushed the prep-v3.8.0-rc.1 branch 2 times, most recently from da08721 to 4c866d7 Compare August 24, 2023 17:54
@hiddeco hiddeco marked this pull request as ready for review August 24, 2023 19:20
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix formatting. The file format is RST, not MarkDown, so double backticks are needed instead of single ones.

Also, don't you need to update version/version.go?

CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
@felixfontein
Copy link
Contributor

I've created #1269 to fix similar issues in the remainder of the file. Turns out nobody ever used proper RST in it for code formatting... (I guess we could also rename this to CHANGELOG.md instead, though I have no idea whether the file is linked from somewhere. In the repo it seems to be only referenced in docs/release.md.)

@hiddeco
Copy link
Member Author

hiddeco commented Aug 25, 2023

Also, don't you need to update version/version.go?

See bit in pull request description around not bumping the version.Version variable.

@hiddeco hiddeco force-pushed the prep-v3.8.0-rc.1 branch 2 times, most recently from 0c09746 to 06dfdbb Compare August 25, 2023 10:40
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Copy link
Contributor

@onedr0p onedr0p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure one day we can pivot to making this file md but for now it's probably good to keep it rst

@felixfontein
Copy link
Contributor

See bit in pull request description around not bumping the version.Version variable.

Yeah, reading helps :) Sorry for the noise.

@hiddeco hiddeco merged commit 7b3a032 into main Aug 25, 2023
7 checks passed
@hiddeco hiddeco deleted the prep-v3.8.0-rc.1 branch August 25, 2023 11:00
@hiddeco
Copy link
Member Author

hiddeco commented Aug 25, 2023

Tiny part of the SLSA provenance attestation failed due to an apparent GitHub Actions outage. But the release is out! 🎉

@hiddeco
Copy link
Member Author

hiddeco commented Aug 25, 2023

Figured out the reason for the failure. As this is a (relatively) new GitHub organization, I forgot to enable the settings which allows a package (container image) to be publicly available. This has been addressed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants