-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare v3.8.0-rc.1 #1268
Prepare v3.8.0-rc.1 #1268
Conversation
da08721
to
4c866d7
Compare
4c866d7
to
64616fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix formatting. The file format is RST, not MarkDown, so double backticks are needed instead of single ones.
Also, don't you need to update version/version.go?
I've created #1269 to fix similar issues in the remainder of the file. Turns out nobody ever used proper RST in it for code formatting... (I guess we could also rename this to CHANGELOG.md instead, though I have no idea whether the file is linked from somewhere. In the repo it seems to be only referenced in |
See bit in pull request description around not bumping the |
0c09746
to
06dfdbb
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
06dfdbb
to
54500a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure one day we can pivot to making this file md but for now it's probably good to keep it rst
Yeah, reading helps :) Sorry for the noise. |
Tiny part of the SLSA provenance attestation failed due to an apparent GitHub Actions outage. But the release is out! 🎉 |
Figured out the reason for the failure. As this is a (relatively) new GitHub organization, I forgot to enable the settings which allows a package (container image) to be publicly available. This has been addressed now. |
For "release note", see: #1266
This does not bump the
version.Version
variable, as this is already done by the build process and this release itself is a release candidate. When the--version
flag in an existingsops
binary would already make use of the GitHub API, it would not report it as "latest" either.