Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mattermost to version v10.4.1 #2080

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

nmfretz
Copy link
Contributor

@nmfretz nmfretz commented Jan 20, 2025

🤖 This is an automated pull request to update mattermost to version v10.4.1. This PR must be reviewed and tested before merging.

@nmfretz
Copy link
Contributor Author

nmfretz commented Jan 20, 2025

🤖 This is an automated summary of installation tests for mattermost:

  • ✅ App successfully installed in umbrel-dev instance
  • ✅ App successfully listed in umbrel.yaml
  • ✅ App UI successfully returns a 200 status code
  • 📸 Screenshot of the app:
    App Screenshot

This PR must still be reviewed and tested before merging.



Full release notes are available at https://docs.mattermost.com/about/mattermost-v10-changelog.html
path: ""
path: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmfretz final newline missing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @al-lac. Added back in here: 0ba25d7. The updater ends up removing newlines at the end of the yml files. Is there a reason we should be keeping them?

I've also added release notes from the changelog 3966429.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep them because of the POSIX standard. Also GitHub shows when new lines are missing at the end.

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ mattermost/docker-compose.yml External port mapping "8443:8443/tcp":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ mattermost/docker-compose.yml External port mapping "8443:8443/udp":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor Author

nmfretz commented Jan 21, 2025

image

@nmfretz nmfretz merged commit 022d3ae into master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants