Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Add Alby #409

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Alby #409

wants to merge 5 commits into from

Conversation

secondl1ght
Copy link

@secondl1ght secondl1ght commented Mar 18, 2022

Hello 👋🏼

I have added Alby instructions as one of the connect wallet options. Please let me know if you require more details.

Thanks!

src/router/index.js Outdated Show resolved Hide resolved
@secondl1ght
Copy link
Author

@AaronDewes do you need anything else from me on this and does everything look good now?

@AaronDewes
Copy link
Contributor

I'm not an Umbrel Dev, so @louneskmt should probably do a final review.

@louneskmt
Copy link
Contributor

Hi @secondl1ght, thanks for your PR!

Unfortunately, I'm not able to setup Alby with my Umbrel. I've installed the companion app for macOS, then clicked on "Install" for Brave. After entering the lndconnect REST Tor URL, Alby is loading for a few seconds or minutes ("Initializing your account. Please wait, this can take a minute..."), then it fails.

image

Does the companion app need to be kept open or is it possible to close it? I've tried both.

Also, I suppose the user needs to have a running Tor instance on their computer. If that's the case, you'll need to add the appropriate step in the instructions (see this review, the added code is the same).

@AaronDewes
Copy link
Contributor

Alby's companion app automatically starts tor, maybe it crashes if it's already running

@louneskmt
Copy link
Contributor

I've stopped my local Tor instance, reinstalled the Alby extension, still the same error.

@louneskmt
Copy link
Contributor

Maybe it comes from my Brave privacy settings?

@AaronDewes
Copy link
Contributor

Maybe it comes from my Brave privacy settings?

Have you restarted your browser after installing the Alby companion app?

@AaronDewes
Copy link
Contributor

I'm not sure if it even works with Brave, this is their screenshot
image

@louneskmt
Copy link
Contributor

Have you restarted your browser after installing the Alby companion app?
Yep, two times.

And Brave is definitely supported for me.

image

I also confirm the presence of the config file in Brave.

image

@secondl1ght
Copy link
Author

Im going to tag @bumi on this, I know he has Alby running on his Umbrel so I think he should be able to help you debug this and get it working.

@bumi
Copy link

bumi commented Apr 10, 2022

Thanks for adding Alby there @secondl1ght
And thanks everyone for testing and reporting that error!
The Alby app does not need to be running. (The browser manages starting/stopping the app in the background. The macOS app is just needed to configure it once).
So it actually looks all good...

Can you check if there is a log file? In the terminal try:tail -n 20 $TMPDIR/alby.log

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants