-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp queries in render/compute pass descriptor #296
Timestamp queries in render/compute pass descriptor #296
Conversation
Updated to match the new API for timestamp writes in Not sure why CI fail on MacOS |
seems like cargo having some problems with wgpu-hal dep, I tested with this rev locally & I can reproduce it. |
Need a rebase or merge trunk |
Done ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good overall!
Just a nit, but pushing through
c7c7174
to
45b405f
Compare
This is an attempt at adding support for the
timestampWrites
field of render and compute pass descriptors.Notable remarks:
wgpu-core
does not match the standardwebgpu.h
. In particular, it does not support different query sets in the same descriptor, nor multiple queries for the same timestamp location (although I admit there must be only very limited use case for these).wgpu-core
performs the check.(Bonus: This PR adds support for the new
gles3_minor_version
instance option.)