Complete Timestamp Query feature implementation #439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the two subfeatures as native features. If these feature definitions move to upstream webgpu.h in the future, it should be a trivial change to change from a native to standard feature.
Test Plan
Verify timestamp writes work in the following cases/apis:
✅Compute pipeline creation
timestampWrites
(WGPUFeature_TimestampQuery
)✅wgpuCommandEncoderWriteTimestamp (
WGPUNativeFeature_TimestampQueryInsideEncoders
)✅wgpuComputePassEncoderWriteTimestamp (
WGPUNativeFeature_TimestampQueryInsidePasses
)output
modified
examples/compute/main.c