Feat: add mmr for Players and Observers #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
suggested changes
Aug 30, 2023
| @@ -285,6 +285,21 @@ def __init__(self, uid, init_data): | |||
| #: This is deprecated because it doesn't actually work. | |||
| self.recorder = None | |||
|
|
|||
| #: The user's mmr at the time of the game | |||
There was a problem hiding this comment.
What is mmr and why does the reader need to guess?
There was a problem hiding this comment.
MMR stands for Matchmaking Rating, indicating the skill level on SC2 ladder. I assume this is a common abbreviation like APM under sc2 context, but now I dont know whether we should explain it in comment or not.
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
reviewed
Aug 30, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
StoicLoofah
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should solve issue #89