Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Enhancements and Bug Fixes #16

Merged
merged 6 commits into from
Jun 22, 2024
Merged

Feature Enhancements and Bug Fixes #16

merged 6 commits into from
Jun 22, 2024

Conversation

gha3mi
Copy link
Owner

@gha3mi gha3mi commented Jun 7, 2024

  • Converted the basis_bspline_der function to a subroutine.
  • Fixed NURBS derivative calculations.
  • Added cmp_Xg() to evaluate the geometry points.
  • Added generic method derivative2() to compute the second derivative of a NURBS objects.
  • Added nearest_point2() to compute the nearest point on a NURBS object using optimization.
  • Added Interfaces.
  • Added new tests: fdm_curve.f90, fdm_surface.f90, fdm_volume.f90.
  • Updated nearest_point_* examples to use the new nearest_point2() method.
  • Made basis and derivative generic methods.
  • Removed intel-classic from CI (ifort is deprecated).

gha3mi added 2 commits June 7, 2024 15:44
Signed-off-by: Seyed Ali Ghasemi <info@gha3mi.com>
Signed-off-by: Seyed Ali Ghasemi <info@gha3mi.com>
@gha3mi gha3mi changed the title Fix NURBS derivatives. Fixed NURBS derivative calculations Jun 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 17.52688% with 767 lines in your changes missing coverage. Please review.

Project coverage is 25.69%. Comparing base (6434ba8) to head (4144211).

Files Patch % Lines
src/forcad_nurbs_volume.f90 3.86% 348 Missing ⚠️
src/forcad_nurbs_surface.f90 4.39% 261 Missing ⚠️
src/forcad_nurbs_curve.f90 16.54% 116 Missing ⚠️
example/nearest_point_1d.f90 0.00% 17 Missing ⚠️
example/nearest_point_3d.f90 0.00% 15 Missing ⚠️
example/nearest_point_2d.f90 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   27.43%   25.69%   -1.75%     
==========================================
  Files          33       36       +3     
  Lines        3382     4183     +801     
  Branches      306      346      +40     
==========================================
+ Hits          928     1075     +147     
- Misses       2385     3039     +654     
  Partials       69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gha3mi added 2 commits June 7, 2024 19:25
Signed-off-by: Seyed Ali Ghasemi <info@gha3mi.com>
Signed-off-by: Seyed Ali Ghasemi <info@gha3mi.com>
Signed-off-by: Seyed Ali Ghasemi <info@gha3mi.com>
@gha3mi gha3mi changed the title Fixed NURBS derivative calculations Feature Enhancements and Bug Fixes Jun 22, 2024
@gha3mi gha3mi marked this pull request as ready for review June 22, 2024 18:29
@gha3mi gha3mi merged commit 206fa79 into main Jun 22, 2024
6 checks passed
@gha3mi gha3mi deleted the dev branch June 22, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants