Skip to content

Commit

Permalink
HPCC-XXXX Add workflow test to check if default helm output changes
Browse files Browse the repository at this point in the history
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
  • Loading branch information
ghalliday committed Sep 7, 2023
1 parent 4719452 commit d40a4ce
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 1 deletion.
58 changes: 58 additions & 0 deletions .github/workflows/check-helm-change.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
name: Check for changein helm output

on:
push:
branches:
- "master"
- "candidate-*"
- "!candidate-7.8.*"
- "!candidate-7.6.*"
- "!candidate-7.4.*"
- "!candidate-7.2.*"
- "!candidate-7.0.*"
- "!candidate-6.*"
pull_request:
branches:
- "master"
- "candidate-*"
- "!candidate-7.8.*"
- "!candidate-7.6.*"
- "!candidate-7.4.*"
- "!candidate-7.2.*"
- "!candidate-7.0.*"
- "!candidate-6.*"

jobs:
pre_job:
# continue-on-error: true # Uncomment once integration is finished
runs-on: ubuntu-20.04
# Map a step output to a job output
outputs:
helm: ${{ steps.skip_check.outputs.helm }}
steps:
- id: skip_check
uses: hpcc-systems/github-actions/changed-modules@main
with:
github_token: ${{ github.token }}
build:
name: "Check helm chart lint"
runs-on: ubuntu-20.04
needs: pre_job
#if: ${{ github.repository == 'hpcc-systems/HPCC-Platform' && needs.pre_job.outputs.helm }}
if: ${{ needs.pre_job.outputs.helm }}
steps:
- uses: actions/checkout@v2
with:
submodules: false
- uses: azure/setup-helm@v3
with:
version: 'latest'
token: ${{ secrets.GITHUB_TOKEN }}
id: install
- name: Test
working-directory: ./testing/helm
run: |
helm template helm/hpcc > ${{ RUNNER_TEMP }}/newoutput.txt
git checkout ${{ $GITHUB_BASE_REF }}
helm template helm/hpcc > ${{ RUNNER_TEMP }}/oldoutput.txt
diff ${{ RUNNER_TEMP }}/oldoutput.txt ${{ RUNNER_TEMP }}/newoutput.txt
2 changes: 1 addition & 1 deletion helm/hpcc/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ Pass in root as .
{{- $certificates := (.Values.certificates | default dict) -}}
{{- $issuers := ($certificates.issuers | default dict) -}}
{{- $security := .Values.security | default dict -}}
deploymentName: {{ (include "hpcc.fullname" (dict "root" $)) }}
deployment: {{ (include "hpcc.fullname" (dict "root" $)) }}
mtls: {{ (include "hpcc.isMtlsEnabled" (dict "root" $)) }}
imageVersion: {{ .Values.global.image.version | default .Chart.Version }}
singleNode: {{ .Values.global.singleNode | default false }}
Expand Down

0 comments on commit d40a4ce

Please sign in to comment.