Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authentication (GSI-1113) #17

Merged
merged 18 commits into from
Nov 29, 2024
Merged

Add authentication (GSI-1113) #17

merged 18 commits into from
Nov 29, 2024

Conversation

Cito
Copy link
Member

@Cito Cito commented Nov 20, 2024 •
edited
Loading

This PR implements the complete 2FA authentication flow in a rudimentary way.

To be done in follow-up PRs (see also TODO markers in the code):

  • Make this work with MSW when this has been integrated, Currently, it only works with the staging backend.
  • Add proper styling to the UI.
  • Add success and error messages where indicated (preferably as toast messages).
  • Add "can activate" guards for verification of the proper session state.
  • Add "can deactivate" guards for making sure that the user "stays in the flow".
  • Check edge cases and multi-tab browsing.

@Cito Cito marked this pull request as ready for review November 27, 2024 16:41
ac-jorellanaf
ac-jorellanaf approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@ac-jorellanaf ac-jorellanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.
Minor comments but approved. 👍

src/app/auth/features/confirm-totp/confirm-totp.component.scss Outdated Show resolved Hide resolved
src/app/portal/features/show-session/show-session.component.html Outdated Show resolved Hide resolved
@Cito Cito merged commit 662b85b into main Nov 29, 2024
1 check passed
@Cito Cito deleted the feature/add-authentication-GSI-1113 branch November 29, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ac-jorellanaf ac-jorellanaf ac-jorellanaf approved these changes

@SilverLinings89 SilverLinings89 Awaiting requested review from SilverLinings89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cito @ac-jorellanaf