Add our brand colours (GSI-1202) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some additional styling to header and footer links. Footer links remain to be wrapped in a button of some sort, but angular material limits button sizes, so custom CSS code needs adding.
Added GHGA logos, added swoosh, fixed footer placement
Fixed colour scheme to light, instead Fixed header mixins
…tyling_changes_GSI-1180
Fixed images stretching with small screens Fixed some issues with small screens
Minor fixes to footer navigation icon alignment
This reverts commit 3211382.
Prettification all around
Overwrote colour variables Added new variables for other GHGA colours
|
Some parameters aren't described (see JSDoc warnings) other than that, everything looks good to me! |
Cito
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
The home page looks good with this workaround.
We may run into problems later because the colors have a different tone than what Material would expect, and we may need to add more manual CSS style rules to apply the right colors instead of letting Material pick the colors based on the role. Also, tternary" and "quinary" are not part of Material and specific to our corporate design. Switching to a different corporate design might become difficult because our workaround is so tailored to this.
But let's go with this for now.
I have pushed a commit that fixes the linter issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerated the palette
Overwrote colour variables
Added new variables for other GHGA colours