Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow colon characters in bucket names #141

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Allow colon characters in bucket names #141

merged 3 commits into from
Nov 19, 2024

Conversation

lkuchenb
Copy link
Member

Unfortunately there is no straight forward way to test this, since localstack does not permit colon names in bucket names either.

https://github.com/localstack/localstack/blob/e8680021583a49697320ae1d65b5683082d0f00c/localstack-core/localstack/services/s3/utils.py#L499-L503

@lkuchenb lkuchenb requested a review from Cito November 19, 2024 08:14
@coveralls
Copy link

coveralls commented Nov 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11912037555

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 92.446%
Totals Coverage Status
Change from base Build 11856051509: 0.2%
Covered Lines: 2056
Relevant Lines: 2224
💛 - Coveralls

TheByronHimes
TheByronHimes reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't made a 4.0 release yet, so you don't need to increase the version number

Cito
Cito approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@Cito Cito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I pushed a commit that changes the regex only for the S3 provider, makes it a bit more restrictive and adds a simple test.

@lkuchenb lkuchenb merged commit 5cec4f8 into main Nov 19, 2024
8 checks passed
@lkuchenb
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheByronHimes TheByronHimes TheByronHimes left review comments

@Cito Cito Cito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lkuchenb @coveralls @Cito @TheByronHimes