Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3 provider test files as package data #69

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

dontseyit
Copy link
Member

This PR updates pyproject.toml to include test files that should be distributed with the package. They were probably excluded by mistake during the template update, this configuration adds them back.

Since these are the only YAML files required are specified as recommended here https://setuptools.pypa.io/en/latest/userguide/datafiles.html#subdirectory-for-data-files

Copy link
Contributor

@KerstenBreuer KerstenBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this so that you are unblocked and can release these changes.

However, could you please have a look at this old PR:
https://github.com/ghga-de/hexkit/pull/65/files#diff-41d5a52589e0480be9c099d2bba7a8135b8b0d71bcbb8df3582a8df1c2295003R1

Using MANIFEST.in file is build system independent.

Would you mind switching to that in a separate PR?

@dontseyit dontseyit merged commit 64462ad into main Nov 2, 2023
3 checks passed
@dontseyit dontseyit deleted the feature/add-package-data-GIM-453 branch November 2, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants