Apply suggestions from code review

Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
ghga-de · May 14, 2024 · 3d7860f · 3d7860f
1 parent 2b95f57
commit 3d7860f
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/metldata/builtin_transformations/infer_relations/model_transform.py b/src/metldata/builtin_transformations/infer_relations/model_transform.py
@@ -45,11 +45,9 @@ def get_relation(element: RelationPathElement, schema: SchemaPack) -> Relation:
     Returns:
         The relation object.
     """
-    if element.type_ == RelationPathElementType.ACTIVE:
-        class_ = schema.classes[element.source]
-    else:
-        class_ = schema.classes[element.target]
-    return class_.relations[element.property]
+    element_active = element.type_ == RelationPathElementType.ACTIVE
+    class_name = element.source if element_active else element.target
+    return schema.classes[class_name].relations[element.property]
 
 
 def infer_mutiplicity_from_path(