Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template and dependency updates #53

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Template and dependency updates #53

merged 11 commits into from
Nov 21, 2023

Conversation

dontseyit
Copy link
Member

This PR updates the microservice template and outdated dependencies.

@coveralls
Copy link

coveralls commented Nov 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6941839950

  • 80 of 80 (100.0%) changed or added relevant lines in 26 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 92.138%
Files with Coverage Reduction New Missed Lines %
src/metldata/builtin_transformations/infer_references/path/path.py 1 93.1%
src/metldata/transform/base.py 1 93.9%
Totals Coverage Status
Change from base Build 6506763230: -0.05%
Covered Lines: 2707
Relevant Lines: 2938
💛 - Coveralls

@dontseyit dontseyit marked this pull request as ready for review November 20, 2023 09:01
@dontseyit
Copy link
Member Author

dontseyit commented Nov 20, 2023 •
edited
Loading

Problems on my initial PR have fixed by @TheByronHimes so the pydantic v2 migration as well as dependency updates should be done now.

KerstenBreuer
KerstenBreuer reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@KerstenBreuer KerstenBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving this PR to our pydantic v2 chief warrior @dontseyit for review :)

TheByronHimes
TheByronHimes approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some pylint ignores that should be taken out, but it's of course not a pressing issue.

src/metldata/artifacts_rest/config.py Outdated Show resolved Hide resolved
src/metldata/artifacts_rest/models.py Outdated Show resolved Hide resolved
src/metldata/builtin_transformations/aggregate/config.py Outdated Show resolved Hide resolved
src/metldata/builtin_transformations/merge_slots/config.py Outdated Show resolved Hide resolved
src/metldata/event_handling/artifact_events.py Outdated Show resolved Hide resolved
src/metldata/load/collect.py Outdated Show resolved Hide resolved
src/metldata/submission_registry/models.py Outdated Show resolved Hide resolved
@dontseyit @TheByronHimes
Delete pylint ignore lines
4e424dd 
Co-authored-by: Byron Himes <byro93@live.com>
@dontseyit dontseyit merged commit 432eb17 into main Nov 21, 2023
5 checks passed
@dontseyit dontseyit deleted the feature/update-dependencies-GIM-462 branch November 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerstenBreuer KerstenBreuer KerstenBreuer left review comments

@TheByronHimes TheByronHimes TheByronHimes approved these changes

@lkuchenb lkuchenb Awaiting requested review from lkuchenb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dontseyit @coveralls @TheByronHimes @KerstenBreuer