generated from ghga-de/microservice-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade schemapack to 2.0.0-alpha3 in 'schemapack' branch #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9080458434Details
💛 - Coveralls |
Cito
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
When running the tests, I get a deprecation warning from pydantic and another user warning. These should be fixed in another PR.
src/metldata/builtin_transformations/delete_properties/model_transform.py
Outdated
Show resolved
Hide resolved
src/metldata/builtin_transformations/infer_relations/data_transform.py
Outdated
Show resolved
Hide resolved
src/metldata/builtin_transformations/infer_relations/model_transform.py
Outdated
Show resolved
Hide resolved
src/metldata/builtin_transformations/infer_relations/model_transform.py
Outdated
Show resolved
Hide resolved
src/metldata/builtin_transformations/infer_relations/model_transform.py
Outdated
Show resolved
Hide resolved
src/metldata/builtin_transformations/infer_relations/model_transform.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
Thanks @Cito, ready for another round |
Cito
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch migrates the
schemapack
branch to schemapack 2.0.0-a3. The previously migrated transformations have been migrated to the current schemapack 2.x standard.Notable changes
path
submodule (which in turn should move up the module hierarchy if we are going to re-use it in other transformations as planned)?dev_launcher
script to re-enable Dockerfile updates through the template update mechanism.