Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade schemapack to 2.0.0-alpha3 in 'schemapack' branch #67

Merged
merged 12 commits into from
May 14, 2024

Conversation

lkuchenb
Copy link
Member

@lkuchenb lkuchenb commented Apr 30, 2024

This patch migrates the schemapack branch to schemapack 2.0.0-a3. The previously migrated transformations have been migrated to the current schemapack 2.x standard.

Notable changes

  • The multiplicity parameter of the infer relations transformation has been removed. I believe the multiplicity and mandatoriness :-) can be inferred as implemented here. However, maybe these should go to the path submodule (which in turn should move up the module hierarchy if we are going to re-use it in other transformations as planned)?
  • I've added a placeholder dev_launcher script to re-enable Dockerfile updates through the template update mechanism.

@lkuchenb lkuchenb marked this pull request as draft April 30, 2024 09:28
@coveralls
Copy link

coveralls commented May 2, 2024

Pull Request Test Coverage Report for Build 9080458434

Details

  • 63 of 67 (94.03%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 93.345%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/metldata/builtin_transformations/infer_relations/data_transform.py 7 9 77.78%
src/metldata/builtin_transformations/infer_relations/model_transform.py 41 43 95.35%
Totals Coverage Status
Change from base Build 8848794681: -0.2%
Covered Lines: 519
Relevant Lines: 556

💛 - Coveralls

@lkuchenb lkuchenb marked this pull request as ready for review May 2, 2024 10:25
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

When running the tests, I get a deprecation warning from pydantic and another user warning. These should be fixed in another PR.

lkuchenb and others added 5 commits May 14, 2024 15:09
Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
@lkuchenb lkuchenb requested a review from Cito May 14, 2024 13:48
@lkuchenb
Copy link
Member Author

Thanks @Cito, ready for another round

@lkuchenb lkuchenb merged commit 2ed8ca3 into schemapack May 14, 2024
4 checks passed
@lkuchenb lkuchenb deleted the feature/upgrade_schemapack branch May 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants