Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Add content property" transformation (GSI-729) #68

Merged
merged 10 commits into from
May 15, 2024

Conversation

lkuchenb
Copy link
Member

@lkuchenb lkuchenb commented May 14, 2024

Implements the "add content property" transformation as described here.

@lkuchenb lkuchenb requested a review from Cito May 14, 2024 15:01
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. See some suggestions below.

lkuchenb and others added 2 commits May 14, 2024 22:10
…sumptions.py

Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
…del_transform.py

Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
@coveralls
Copy link

coveralls commented May 14, 2024

Pull Request Test Coverage Report for Build 9085577864

Details

  • 111 of 119 (93.28%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 93.333%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/metldata/builtin_transformations/add_content_properties/assumptions.py 15 17 88.24%
src/metldata/builtin_transformations/add_content_properties/data_transform.py 18 20 90.0%
src/metldata/builtin_transformations/add_content_properties/model_transform.py 23 27 85.19%
Totals Coverage Status
Change from base Build 9081530249: -0.01%
Covered Lines: 630
Relevant Lines: 675

💛 - Coveralls

lkuchenb and others added 2 commits May 15, 2024 08:09
Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>
@lkuchenb
Copy link
Member Author

@Cito thanks for your feedback, ready for another round.

@lkuchenb lkuchenb requested a review from Cito May 15, 2024 11:02
@lkuchenb lkuchenb merged commit 7052672 into schemapack May 15, 2024
4 checks passed
@lkuchenb lkuchenb deleted the feature/add_content_property_GSI-729 branch May 15, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants