Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring #69

Merged
merged 3 commits into from
May 17, 2024
Merged

Minor refactoring #69

merged 3 commits into from
May 17, 2024

Conversation

lkuchenb
Copy link
Member

  • Move the NewContentSchemaPath class to a common module to be reused in other transformations
  • Homologise import logic between transformations
  • Fix copy & paste error in docstring

@lkuchenb lkuchenb requested review from Cito and mephenor and removed request for Cito May 16, 2024 13:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9113179265

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 93.411%
Totals Coverage Status
Change from base Build 9096145611: 0.08%
Covered Lines: 638
Relevant Lines: 683
💛 - Coveralls

@lkuchenb lkuchenb merged commit c8ce093 into schemapack May 17, 2024
4 checks passed
@lkuchenb lkuchenb deleted the feature/minor_refactoring branch May 17, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mephenor mephenor mephenor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkuchenb @coveralls @mephenor