-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Count references #77
Count references #77
Conversation
Pull Request Test Coverage Report for Build 10594027772Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source vs. target needs to be changed to active vs. passive and both directions handled, as discussed.
In addition, there is some documentation that needs a bit more work put into.
src/metldata/builtin_transformations/count_references/instruction.py
Outdated
Show resolved
Hide resolved
src/metldata/builtin_transformations/count_references/config.py
Outdated
Show resolved
Hide resolved
src/metldata/builtin_transformations/count_references/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Zajac <thomas-jakob.zajac@uni-tuebingen.de>
Co-authored-by: Thomas Zajac <thomas-jakob.zajac@uni-tuebingen.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good now apart from one tiny thing.
Up to your discretion if you want to change that
This PR adds the functionality of counting references transformation. It counts how many target objects are referenced from each source object given the relation name and adds the value to the corresponding datapack-content-properties. Since it builds on top of the "add content property" transformation, it assumes that the "path to target content(s)" is already present in its input SchemaPack and DataPack.