Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

property is added to the schema through count references transformation #79

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

sbilge
Copy link
Member

@sbilge sbilge commented Sep 3, 2024

The object_path(given in the config for this transformation) will be added by the add_content_properties transformation. However, the property_name will not be included in that transformation. As a result, if the property_name exists in the pre-transformed model, it should fail the model assumptions. The property_name needs to be added during the model transformation phase of count_references.

This PR introduces a fix to model transformation based on the requirements explained above.

@sbilge sbilge requested a review from mephenor September 3, 2024 08:39
Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

@sbilge sbilge requested a review from mephenor September 3, 2024 12:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10682962794

Details

  • 15 of 17 (88.24%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 92.745%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/metldata/builtin_transformations/count_references/model_transform.py 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
src/metldata/builtin_transformations/count_references/assumptions.py 1 84.21%
src/metldata/builtin_transformations/count_references/model_transform.py 1 85.19%
Totals Coverage Status
Change from base Build 10594717949: 0.07%
Covered Lines: 767
Relevant Lines: 827

💛 - Coveralls

@sbilge sbilge merged commit f8e543a into schemapack Sep 3, 2024
4 checks passed
@sbilge sbilge deleted the count_refences_fix_property branch September 3, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants