Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hexkit, use Pydantic V2 and refactor DI (GSI-443) #16

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Update hexkit, use Pydantic V2 and refactor DI (GSI-443) #16

merged 4 commits into from
Oct 27, 2023

Conversation

Cito
Copy link
Member

@Cito Cito commented Oct 27, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6665855487

  • 82 of 97 (84.54%) changed or added relevant lines in 12 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 89.216%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/wps/cli.py 0 2 0.0%
src/wps/adapters/inbound/fastapi_/configure.py 12 17 70.59%
src/wps/main.py 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/wps/main.py 2 0.0%
Totals Coverage Status
Change from base Build 6455186276: -0.2%
Covered Lines: 455
Relevant Lines: 510
💛 - Coveralls

TheByronHimes
TheByronHimes approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell it looks good.

@Cito Cito removed the request for review from KerstenBreuer October 27, 2023 14:00
@Cito Cito merged commit a9a8cbd into main Oct 27, 2023
6 checks passed
@Cito Cito deleted the feature/refactor-di-GSI-443 branch October 27, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheByronHimes TheByronHimes TheByronHimes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cito @TheByronHimes