Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configured logging (GSI-614) #19

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

TheByronHimes
Copy link
Member

Adds the LoggingConfig to the service's config class and calls configure_logging in the entry functions.
I added log statements for the errors in the core repository module.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7813755266

  • -37 of 64 (42.19%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-3.8%) to 85.432%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/wps/adapters/inbound/event_sub.py 2 3 66.67%
src/wps/main.py 0 3 0.0%
src/wps/core/repository.py 21 54 38.89%
Files with Coverage Reduction New Missed Lines %
src/wps/adapters/inbound/event_sub.py 1 93.02%
Totals Coverage Status
Change from base Build 7811761936: -3.8%
Covered Lines: 475
Relevant Lines: 556

💛 - Coveralls

Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
If we could only reuse extra details in every service...

@TheByronHimes TheByronHimes merged commit 5aed6d0 into main Feb 7, 2024
9 checks passed
@TheByronHimes TheByronHimes deleted the feature/use_configured_logging_GSI-614 branch February 7, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants