Only notify of selection change for events triggered from this librar…

…y to avoid recursive crazyness
gidztech · May 9, 2017 · fd06aca · fd06aca
1 parent 61e5225
commit fd06aca
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/demo/bundle.js b/demo/bundle.js
diff --git a/dist/simple-list-item-range-selector.js b/dist/simple-list-item-range-selector.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "simple-list-item-range-selector",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "Small UI library that allows you to take a list of items and attach selection events to it",
   "main": "dist/simple-list-item-range-selector.js",
   "scripts": {

diff --git a/src/js/simple-list-item-range-selector.js b/src/js/simple-list-item-range-selector.js
@@ -119,7 +119,7 @@ let SimpleListItemRangeSelector = {
             }
         }
 
-        function _updateDOM(selection) {
+        function _updateDOM(selection, notify) {
             let selectedItems = [];
             let sortedSelection = selection.concat().sort();
 
@@ -143,7 +143,9 @@ let SimpleListItemRangeSelector = {
                 }
             }
 
-            _onSelectionChanged(selectedItems);
+            if (notify) {
+                _onSelectionChanged(selectedItems);
+            }
         }
 
         function _updateSelection(e, updateDOM) {
@@ -177,7 +179,7 @@ let SimpleListItemRangeSelector = {
                     // first item selected had shift modified applied so just select it normally
                     _newSelection.push(selectedItemIndex);
                     _lastClickedIndexWithoutShift = selectedItemIndex;
-                    updateDOM(_newSelection);
+                    updateDOM(_newSelection, true);
                     return;
                 }
 
@@ -231,7 +233,7 @@ let SimpleListItemRangeSelector = {
                 }
             }
 
-            updateDOM(_newSelection);
+            updateDOM(_newSelection, true);
         }
 
         function _selectItemsWithinRange({start, end}) {
@@ -273,7 +275,7 @@ let SimpleListItemRangeSelector = {
 
         function _clearAllSelectionsHandler() {
             _newSelection = [];
-            _updateDOM(_newSelection);
+            _updateDOM(_newSelection, false);
         }
 
         function _preventDefaultHandler(e) {
@@ -316,7 +318,7 @@ let SimpleListItemRangeSelector = {
                 _newSelection.push(index);
             }
 
-            _updateDOM(_newSelection);
+            _updateDOM(_newSelection, false);
         }
 
         function _unselectItem(item) {
@@ -325,7 +327,7 @@ let SimpleListItemRangeSelector = {
                 _unselectItemAtIndex(index);
             }
 
-            _updateDOM(_newSelection);
+            _updateDOM(_newSelection, false);
         }
 
         function _disableRangeSelection() {