Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for supporting ECL #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Changes for supporting ECL #2

wants to merge 3 commits into from

Conversation

juanjosegarciaripoll
Copy link

These changes address two major issues

  • set-timeouts was not implemented in ECL. I have pushed a possible implementation, though I have found that removing timeouts seems to be the optimal operation mode for what I do.
  • ECL can compile various libraries into a single program. However TOOT has various unneeded dependencies on the ASDF package. This prevents users from building standalone executables. The way I solved this was by defining the toot-version in the TOOT package and also by removing the test server and separating it as a different ASDF file -- if someone needs it, free to use, but this is most likely not the case.

@@ -48,6 +48,12 @@ set."
#+:clisp
(when write-timeout
(socket:socket-options (usocket:socket usocket) :SO-SNDTIMEO write-timeout))
#+:ecl
(when read-timeout
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really supposed to be checking read-timeout?

@juanjosegarciaripoll
Copy link
Author

Yes, you are right. I made a mistake through cut&paste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants