Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE9 does 0x00 byte truncation after message decoding with MessageEvent #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nyanna
Copy link

@Nyanna Nyanna commented Mar 12, 2013

not only Opera shows the 0x00 byte truncation bug. IE9 shows the same behavior so IE9 should also use the closure fix.

behavior so IE9 should also use the closure fix.
@gimite
Copy link
Owner

gimite commented Mar 24, 2013

Thanks for the patch and sorry for late. I'll take a look soon.

@Nyanna
Copy link
Author

Nyanna commented Apr 9, 2013

no problem, its not urgent.

@gimite
Copy link
Owner

gimite commented Apr 25, 2013

I tried sending "foo\0bar" to IE9 and it was handled correctly. Have you tried the same code with Chrome? If it happens in Chrome too, it's likely that your server has problem sending null bytes, not client.

@Nyanna
Copy link
Author

Nyanna commented Apr 25, 2013

Tobias and i had several tests, under chrome it did functioning. Maybe its related to a specific library IE9 is using, windows service packs, hotfixes, windows version etc.
When the server should be the cause, why this get fixed with the pushed workaround?
Clear to us is that the IE9 is likely to show the same behavior as already reported and we simply skiped the "copy to native api"-action.
I would guess that has something todo wihtin a copy loop that breaks on standard C zero byte string termination.

Maybe on the next release we can send u the real usecase u can test on.

@gimite
Copy link
Owner

gimite commented Apr 25, 2013

I found that IE9 doesn't define either document.createEvent nor window.MessageEvent. So usually it doesn't go to code path using document.createEvent in IE9 anyway. Maybe one of the libraries you are using defines document.createEvent and window.MessageEvent, and the implementation has a bug truncating after null byte?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants