Ipc 407 alternative texts and payment flow fix #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicretu
reviewed
Dec 11, 2024
| @@ -329,6 +329,14 @@ class PaymentFragment private constructor( | |||
| if (childFragmentManager.fragments.any { it is PaymentComponentBottomSheet }) { | |||
| return | |||
| } | |||
|
|
|||
| if (!viewModel.giniInternalPaymentModule.getReturningUser() && viewModel.documentId != null) { | |||
There was a problem hiding this comment.
[Clarification] Does this case only apply to flows with document? For flows without document, we have the same steps as before?
…ent and `ReviewBottomSheet` configured to visible after selecting bank IPC-407
|
danicretu
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also contains fix for the payment flow for new users (skipping "Continue to overview" status after initial bank selection. After my own tests it is working as expected, but after review the Entry points for new user should go through a quick test.