Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make default item lists look less different than before #1651 #1668

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Make default item lists look less different than before #1651 #1668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

- Better handle images without enough tile layers ([#1648](../../pull/1648))
- Add users option to config files; have a default config file ([#1649](../../pull/1649))
- Remove no longer used code; adjust item list slightly ([#1651](../../pull/1651))
- Remove no longer used code; adjust item list slightly ([#1651](../../pull/1651), [#1668](../../pull/1668))
- Reduce updates when showing item lists; add a waiting spinner ([#1653](../../pull/1653))
- Update item lists check for large images when toggling recurse ([#1654](../../pull/1654))
- Support named item lists ([#1665](../../pull/1665))
Expand Down
7 changes: 7 additions & 0 deletions girder/girder_large_image/web_client/stylesheets/itemList.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,13 @@ ul.g-item-list
&>li>.li-item-list-cell
display inline-block

ul.g-item-list[metadata-columns="0"]
.li-column-record-size
text-wrap no-wrap

.li-column-record-name
width 100%

.li-item-list-filter
padding-left 12px

Expand Down
3 changes: 2 additions & 1 deletion girder/girder_large_image/web_client/templates/itemList.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
ul.g-item-list.li-item-list(layout_mode=(itemList.layout || {}).mode || '')
- var metadataCount = itemList.columns.filter((col) => col.type === 'metadata').length
ul.g-item-list.li-item-list(layout_mode=(itemList.layout || {}).mode || '', metadata-columns=metadataCount)
- var colNames = [];
if items.length
li.li-item-list-header
Expand Down