-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3 Issue Footer Component #16
base: develop
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/girlscript-blr/build-with-gsblr-raahat/mtdtr3v0o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please prettify the code if possible! Using prettier extension!
src/App.js
Outdated
return ( | ||
<div> | ||
<Router> | ||
<Switch> | ||
<Route path="/" exact component={Header}/> | ||
<Route path="/" exact component={footer}/> | ||
</Switch> | ||
</Router> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not the correct.
- Routing is all about different pages!
- Footer Component will come below the outside Switch Tag!
- For more details, Refer how to do routing in this video! https://www.youtube.com/watch?v=Law7wfdg_ls&t=1778s
- F for footer will be capitalized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have corrected
- F capital in footer component.
- Outside switch tag added route path with /Footer so is this correct ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @smilegupta I changed the code but am stuck in the pr. I dont know why its having every new pr while commiting the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karshil2309 what exactly are facing issue!? Can you brief more about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smilegupta I have done the changes but I did some blunders with git. So may be my code hasnt been updated. Can I do new PR and update it ?
src/components/Footer/footer.js
Outdated
|
||
|
||
|
||
function footer() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F should be capitalised for this fuction name!
@smilegupta Please review PR done the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the footer created is not properly aligned with the provided wireframe. Please do the needful changes.
Also we see that you have raised one more PR #31 . Either do the final changes on this or the other PR.
src/components/Footer/footer.js
Outdated
<a | ||
href="https://www.facebook.com/" | ||
className="facebook social" | ||
> | ||
<FontAwesomeIcon icon={faFacebook} size="5x" /> | ||
</a> | ||
<a | ||
href="https://www.linkedin.com/" | ||
className="linkedin social" | ||
> | ||
<FontAwesomeIcon icon={faLinkedin} size="5x" /> | ||
</a> | ||
<a | ||
href="https://www.telegram.com/" | ||
className="telegram social" | ||
> | ||
<FontAwesomeIcon icon={faTelegram} size="5x" /> | ||
</a> | ||
|
||
<a | ||
href="https://www.instagram.com/" | ||
className="instagram social" | ||
> | ||
<FontAwesomeIcon icon={faInstagram} size="5x" /> | ||
</a> | ||
<a | ||
href="https://www.medium.com/" | ||
className="medium social" | ||
> | ||
<FontAwesomeIcon icon={faMedium} size="5x" /> | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay will do that..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need any help? You are the last guy whose PR is not got accepted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please, while adding the background color, the page is not looking as per design.
Updated the footer code. Please check. Thank you!!!