Skip to content

Commit

Permalink
sequencer: remove use of comment character
Browse files Browse the repository at this point in the history
Instead of using the hardcoded `# `, use the
user-defined comment_line_char.  Adds a test
to prevent regressions.

Signed-off-by: Tony Tung <tonytung@merly.org>
  • Loading branch information
ttung committed Oct 27, 2023
1 parent 2e8e77c commit 10598a5
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 2 deletions.
5 changes: 3 additions & 2 deletions sequencer.c
Original file line number Diff line number Diff line change
Expand Up @@ -6082,8 +6082,9 @@ static int add_decorations_to_list(const struct commit *commit,
/* If the branch is checked out, then leave a comment instead. */
if ((path = branch_checked_out(decoration->name))) {
item->command = TODO_COMMENT;
strbuf_addf(ctx->buf, "# Ref %s checked out at '%s'\n",
decoration->name, path);
strbuf_commented_addf(ctx->buf, comment_line_char,
"Ref %s checked out at '%s'\n",
decoration->name, path);
} else {
struct string_list_item *sti;
item->command = TODO_UPDATE_REF;
Expand Down
39 changes: 39 additions & 0 deletions t/t3404-rebase-interactive.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1839,6 +1839,45 @@ test_expect_success '--update-refs adds label and update-ref commands' '
)
'

test_expect_success '--update-refs works with core.commentChar' '
git checkout -b update-refs-with-commentchar no-conflict-branch &&
test_config core.commentChar : &&
git branch -f base HEAD~4 &&
git branch -f first HEAD~3 &&
git branch -f second HEAD~3 &&
git branch -f third HEAD~1 &&
git commit --allow-empty --fixup=third &&
git branch -f is-not-reordered &&
git commit --allow-empty --fixup=HEAD~4 &&
git branch -f shared-tip &&
git checkout update-refs &&
(
write_script fake-editor.sh <<-\EOF &&
grep "^[^:]" "$1"
exit 1
EOF
test_set_editor "$(pwd)/fake-editor.sh" &&
cat >expect <<-EOF &&
pick $(git log -1 --format=%h J) J
fixup $(git log -1 --format=%h update-refs) fixup! J : empty
update-ref refs/heads/second
update-ref refs/heads/first
pick $(git log -1 --format=%h K) K
pick $(git log -1 --format=%h L) L
fixup $(git log -1 --format=%h is-not-reordered) fixup! L : empty
update-ref refs/heads/third
pick $(git log -1 --format=%h M) M
update-ref refs/heads/no-conflict-branch
update-ref refs/heads/is-not-reordered
update-ref refs/heads/update-refs-with-commentchar
EOF
test_must_fail git rebase -i --autosquash --update-refs primary shared-tip >todo &&
test_cmp expect todo
)
'

test_expect_success '--update-refs adds commands with --rebase-merges' '
git checkout -b update-refs-with-merge no-conflict-branch &&
git branch -f base HEAD~4 &&
Expand Down

0 comments on commit 10598a5

Please sign in to comment.