-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: whitespace check #1726
ci: whitespace check #1726
Conversation
Sections of CI output defined by `begin_group()` and `end_group()` are expanded in GitLab pipelines by default. This can make CI job output rather noisy and harder to navigate. Update the behavior for GitLab pipelines to now collapse sections by default. Signed-off-by: Justin Tobler <jltobler@gmail.com>
There are issues in commit 1454be2: |
There are issues in commit 1454be2: |
There are issues in commit 6559917: |
6559917
to
8fc7b78
Compare
There are issues in commit 2d73d79: |
There are issues in commit 8fc7b78: |
8fc7b78
to
3cc0991
Compare
There are issues in commit c844677: |
There are issues in commit 3cc0991: |
3cc0991
to
345a848
Compare
There are issues in commit 5b138b0: |
There are issues in commit 345a848: |
345a848
to
ff388e6
Compare
There are issues in commit 60e65ab: |
There are issues in commit ff388e6: |
ff388e6
to
bd93501
Compare
There are issues in commit 93610eb: |
There are issues in commit bd93501: |
bd93501
to
4835903
Compare
There are issues in commit 818783e: |
There are issues in commit 4835903: |
4835903
to
1c43418
Compare
There are issues in commit b0db38b: |
1 similar comment
There are issues in commit b0db38b: |
b0db38b
to
d4ad9e4
Compare
There are issues in commit d4ad9e4: |
When the `check-whitespace` CI job detects whitespace errors, a formatted summary of the issue is generated. This summary contains links to the commits and blobs responsible for the whitespace errors. The generated links for blobs do not work and result in a 404. Instead of using the reference name in the link, use the commit ID directly. This fixes the broken link and also helps enable future generalization of the script for other CI providers by removing one of the GitHub specific CI variables used. Signed-off-by: Justin Tobler <jltobler@gmail.com>
d4ad9e4
to
a62e1bc
Compare
There are issues in commit a62e1bc: |
The `check-whitespace` CI job is only available as a GitHub action. To help enable this job with other CI providers, first separate the logic performing the whitespace check into its own script. In subsequent commits, this script is further generalized allowing its reuse. Helped-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Justin Tobler <jltobler@gmail.com>
The `check-whitespace` CI job generates a formatted output file containing whitespace error information. As not all CI providers support rendering a formatted summary, make its generation optional. Signed-off-by: Justin Tobler <jltobler@gmail.com>
a62e1bc
to
4641ff2
Compare
There are issues in commit 4641ff2: |
GitLab CI does not have a job to check for whitespace errors introduced by a set of changes. Reuse the existing generic `whitespace-check.sh` to create the job for GitLab pipelines. Note that the `$CI_MERGE_REQUEST_TARGET_BRANCH_SHA` variable is only available in GitLab merge request pipelines and therefore the CI job is configured to only run as part of those pipelines. Signed-off-by: Justin Tobler <jltobler@gmail.com>
4641ff2
to
175b300
Compare
Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list (git@vger.kernel.org) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.
For a single-commit pull request, please leave the pull request description
empty: your commit message itself should describe your changes.
Please read the "guidelines for contributing" linked above!