-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: rename clar-related variables to avoid confusion #1795
Conversation
In c3de556 (Makefile: rename clar-related variables to avoid confusion, 2024-09-10) some `Makefile` variables were renamed that were partially used by the CMake definition. Adapt the latter to the new lay of the land. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
/submit |
Submitted as pull.1795.git.1726687276169.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
On the Git mailing list, Junio C Hamano wrote (reply to this): "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> In c3de556a841f (Makefile: rename clar-related variables to avoid
> confusion, 2024-09-10) some `Makefile` variables were renamed that were
> partially used by the CMake definition. Adapt the latter to the new lay
> of the land.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> cmake: rename clar-related variables to avoid confusion
>
> This is an add-on for ps/clar-unit-tests to let it build with CMake and
> Visual C.
Thanks.
The base topic is expected to graduate to 'master' in a day or two,
so this is a very timely and welcome update. |
This patch series was integrated into seen via git@35b7d19. |
This patch series was integrated into seen via git@2c4e8a8. |
This patch series was integrated into next via git@d892dcd. |
This patch series was integrated into seen via git@a452b34. |
This patch series was integrated into seen via git@9a970bd. |
On the Git mailing list, Patrick Steinhardt wrote (reply to this): On Wed, Sep 18, 2024 at 07:21:16PM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> In c3de556a841f (Makefile: rename clar-related variables to avoid
> confusion, 2024-09-10) some `Makefile` variables were renamed that were
> partially used by the CMake definition. Adapt the latter to the new lay
> of the land.
Ah, thanks for the fixup! I really hope that I can (soonish) make the
case for CMake being part of our officially supported build systems that
is also exercised as part of our CI.
Patrick |
User |
This patch series was integrated into seen via git@1050870. |
This patch series was integrated into seen via git@cbb5b53. |
This patch series was integrated into master via git@cbb5b53. |
This patch series was integrated into next via git@cbb5b53. |
Closed via cbb5b53. |
This is an add-on for
ps/clar-unit-tests
to let it build with CMake and Visual C.cc: Patrick Steinhardt ps@pks.im