Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: rename clar-related variables to avoid confusion #1795

Closed
wants to merge 1 commit into from

Conversation

dscho
Copy link
Member

@dscho dscho commented Sep 18, 2024

This is an add-on for ps/clar-unit-tests to let it build with CMake and Visual C.

cc: Patrick Steinhardt ps@pks.im

In c3de556 (Makefile: rename clar-related variables to avoid
confusion, 2024-09-10) some `Makefile` variables were renamed that were
partially used by the CMake definition. Adapt the latter to the new lay
of the land.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member Author

dscho commented Sep 18, 2024

/submit

Copy link

gitgitgadget bot commented Sep 18, 2024

Submitted as pull.1795.git.1726687276169.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1795/dscho/clar-unit-tests+cmake-v1

To fetch this version to local tag pr-1795/dscho/clar-unit-tests+cmake-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1795/dscho/clar-unit-tests+cmake-v1

Copy link

gitgitgadget bot commented Sep 19, 2024

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> In c3de556a841f (Makefile: rename clar-related variables to avoid
> confusion, 2024-09-10) some `Makefile` variables were renamed that were
> partially used by the CMake definition. Adapt the latter to the new lay
> of the land.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>     cmake: rename clar-related variables to avoid confusion
>     
>     This is an add-on for ps/clar-unit-tests to let it build with CMake and
>     Visual C.

Thanks.  

The base topic is expected to graduate to 'master' in a day or two,
so this is a very timely and welcome update.

Copy link

gitgitgadget bot commented Sep 19, 2024

This patch series was integrated into seen via git@35b7d19.

@gitgitgadget gitgitgadget bot added the seen label Sep 19, 2024
Copy link

gitgitgadget bot commented Sep 19, 2024

This patch series was integrated into seen via git@2c4e8a8.

Copy link

gitgitgadget bot commented Sep 19, 2024

This patch series was integrated into next via git@d892dcd.

@gitgitgadget gitgitgadget bot added the next label Sep 19, 2024
Copy link

gitgitgadget bot commented Sep 20, 2024

This patch series was integrated into seen via git@a452b34.

Copy link

gitgitgadget bot commented Sep 23, 2024

This patch series was integrated into seen via git@9a970bd.

Copy link

gitgitgadget bot commented Sep 24, 2024

On the Git mailing list, Patrick Steinhardt wrote (reply to this):

On Wed, Sep 18, 2024 at 07:21:16PM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> In c3de556a841f (Makefile: rename clar-related variables to avoid
> confusion, 2024-09-10) some `Makefile` variables were renamed that were
> partially used by the CMake definition. Adapt the latter to the new lay
> of the land.

Ah, thanks for the fixup! I really hope that I can (soonish) make the
case for CMake being part of our officially supported build systems that
is also exercised as part of our CI.

Patrick

Copy link

gitgitgadget bot commented Sep 24, 2024

User Patrick Steinhardt <ps@pks.im> has been added to the cc: list.

Copy link

gitgitgadget bot commented Sep 24, 2024

This patch series was integrated into seen via git@1050870.

Copy link

gitgitgadget bot commented Sep 25, 2024

This patch series was integrated into seen via git@cbb5b53.

Copy link

gitgitgadget bot commented Sep 25, 2024

This patch series was integrated into master via git@cbb5b53.

Copy link

gitgitgadget bot commented Sep 25, 2024

This patch series was integrated into next via git@cbb5b53.

@gitgitgadget gitgitgadget bot added the master label Sep 25, 2024
@gitgitgadget gitgitgadget bot closed this Sep 25, 2024
Copy link

gitgitgadget bot commented Sep 25, 2024

Closed via cbb5b53.

@dscho dscho deleted the clar-unit-tests+cmake branch September 26, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant