V2

[keithamus]

v2 is a branch made of the following PRs:

• remove controller or component suffix from registered elements #219
• remove autoshadowroot #220
• ensure register tests extend HTMLElement #240
• Refactor bind into actionable #250
• refactor attr into attrable #251
• add new attr docs #252
• refactor target into targetable #257
• V2 doc improvements #259
• remove hidden true from v2 pages #260
• add composition tests for providable #261
• use shadowroot.host instead of weakmap #284

These PRs are introducing breaking changes to the codebase, which is why they've been merged into this branch.

[keithamus]

I've released a 2.0.0-alpha of this branch: https://github.com/github/catalyst/releases/tag/v2.0.0-alpha1. We'll test this out and kick the tires on it for a while before merging.

[primer-css]

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

• 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
• ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
• ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

[adoublef]

I am unsure what the status is with v2 so I understand that it's still unstable and subject to changes. I am however finding in comparison to v1 that I am unable to use the target decorator to find the an element that is inside a shadowRoot

Hopefully I am not speaking out of turn with this. But I think the issue was due to the order in with the abilities are called in the in the controller decorator. Seems when I change the function body to register(targetable(actionable(attrable((Class))))); 

In the targetable.ts file it set's the shadowRoot to the weakmap which I think was not being called (or overwritten) with the original controller decorator